Skip to content

local_connect_and_auth takes 2 arguments, 3 given #29023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Matzz wants to merge 1 commit into from
Closed

local_connect_and_auth takes 2 arguments, 3 given #29023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion python/pyspark/rdd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ def _parse_memory(s):


def _load_from_socket(sock_info, serializer):
(sockfile, sock) = local_connect_and_auth(*sock_info)
port = sock_info[0]
auth_secret = sock_info[1]
(sockfile, sock) = local_connect_and_auth(port, auth_secret)
Copy link
Member

@HyukjinKwon HyukjinKwon Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was correctly ported back at #25593. There's no such code you pointed out in Spark 2.4.4: https://github.com/apache/spark/blob/v2.4.4/python/pyspark/sql/dataframe.py#L2182.

Are you using your own fork or mixing the Spark versions? Your error message seems from https://github.com/apache/spark/blob/v2.4.3/python/pyspark/sql/dataframe.py#L2179 which is Spark 2.4.3. Spark 2.4.3 does not have this change.

Copy link

@onzo-mateuszzakarczemny onzo-mateuszzakarczemny Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon You are linking to dataframe.py but I patched rdd.py
The code is there:
https://github.com/apache/spark/blob/v2.4.4/python/pyspark/rdd.py#L144

So (*sock_info) is used instead of passing individual touple values.

Copy link

@onzo-mateuszzakarczemny onzo-mateuszzakarczemny Jul 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I see now. It is possible that that I messed something while using pipenv.
Anyway I feel that using (*sock_info) is inherently unsafe and prone to such errors.

Copy link
Member

@HyukjinKwon HyukjinKwon Jul 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I actually already pointed it out it's error-prone in the previous PR. Feel free to open another PR to fix it.

# The RDD materialization time is unpredicable, if we set a timeout for socket reading
# operation, it will very possibly fail. See SPARK-18281.
sock.settimeout(None)
Expand Down