Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR proposes to partially reverts the simple string in NullType at #28833: NullType.simpleString back from unknown to null.

Why are the changes needed?

Does this PR introduce any user-facing change?

It reverts back the user-facing changes at #28833.
The simple string of NullType is back to null.

How was this patch tested?

I just logically reverted. Jenkins should test it out.

@SparkQA

This comment has been minimized.

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA

This comment has been minimized.

@SparkQA
Copy link

SparkQA commented Jul 9, 2020

Test build #125432 has finished for PR 29041 at commit 474cc70.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member Author

retest this please

@SparkQA
Copy link

SparkQA commented Jul 9, 2020

Test build #125442 has finished for PR 29041 at commit 474cc70.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Retest this please.

@SparkQA
Copy link

SparkQA commented Jul 10, 2020

Test build #125503 has finished for PR 29041 at commit 474cc70.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master. Thank you, @HyukjinKwon .

@HyukjinKwon
Copy link
Member Author

Thank you @dongjoon-hyun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants