Skip to content

Conversation

@srowen
Copy link
Member

@srowen srowen commented Oct 23, 2014

This follows #2893 , but does not completely fix SPARK-3359 either. This fixes minor scaladoc/javadoc issues that Javadoc 8 will treat as errors.

…all of the errors turned up when javadoc 8 runs on output of genjavadoc.
@SparkQA
Copy link

SparkQA commented Oct 23, 2014

QA tests have started for PR 2909 at commit f62c347.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 23, 2014

QA tests have finished for PR 2909 at commit f62c347.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22074/
Test PASSed.

@mengxr
Copy link
Contributor

mengxr commented Oct 24, 2014

@srowen Do you plan to fix more unidoc errors in this PR?

@srowen
Copy link
Member Author

srowen commented Oct 24, 2014

@mengxr This is all I think is fixable without starting to take away from the valid scaladoc. For example we'd have to remove @group tags and remove several links to methods. Really genjavadoc needs a few enhancements to address this otherwise. I think this is a step forward for the JIRA but does not fix it.

@mengxr
Copy link
Contributor

mengxr commented Oct 26, 2014

LGTM. Verified that < shows up correctly in generated Scala and Java docs. Merged into master. Thanks!

@asfgit asfgit closed this in df7974b Oct 26, 2014
@srowen srowen deleted the SPARK-3359 branch October 26, 2014 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants