[SPARK-32327][SQL] SHOW TBLPROPERTIES is not allowed on temporary views

[imback82]

What changes were proposed in this pull request?

This PR proposes to disallow SHOW TBLPROPERTIES on a temporary view as discussed here: #28375 (comment).

Why are the changes needed?

Creating temporary views with properties is not allowed, and SHOW TBLPROPERTIES on temporary views can also be disabled to be consistent.

Does this PR introduce any user-facing change?

Yes,
Before:

scala> sql("CREATE TEMPORARY VIEW tv TBLPROPERTIES('p1'='v1') AS SELECT 1 AS c1")
res0: org.apache.spark.sql.DataFrame = []

scala> sql("SHOW TBLPROPERTIES tv").show
+---+-----+
|key|value|
+---+-----+
+---+-----+

After:

scala> sql("CREATE TEMPORARY VIEW tv TBLPROPERTIES('p1'='v1') AS SELECT 1 AS c1")
res0: org.apache.spark.sql.DataFrame = []

scala> sql("SHOW TBLPROPERTIES tv").show
org.apache.spark.sql.AnalysisException: tv is a temp view, not a table or permanent view.; line 1 pos 0
  at org.apache.spark.sql.catalyst.analysis.package$AnalysisErrorAt.failAnalysis(package.scala:42)
  at org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveTempViews$$anonfun$apply$7.$anonfun$applyOrElse$42(Analyzer.scala:863)
  at scala.Option.foreach(Option.scala:407)
...

How was this patch tested?

Updated existing tests

[SparkQA]

Test build #125923 has finished for PR 29127 at commit a17696b.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
• case class UnresolvedTableOrPermanentView(multipartIdentifier: Seq[String]) extends LeafNode

[imback82]

This will not be hit if you go thru SHOW TBLPROPERTIES command.

[imback82]

cc: @cloud-fan @viirya

[cloud-fan]

shall we simply add an acceptTempView flag here instead of adding UnresolvedTableOrPermanentView?

[cloud-fan]

At first glance, I thought the PR description is confusing, because we can specify properties of temp view but can't display it. Then I realized that we just ignore the properties when creating temp views.

I think we should fail the temp view creating instead of silently ignoring the table properties when specified. @imback82 can you fix this first?

[imback82]

I think we should fail the temp view creating instead of silently ignoring the table properties when specified. @imback82 can you fix this first?

Will do.

[cloud-fan]

Now I don't have a strong opinion. Users can't create temp view with properties and it seems fine if SHOW TBLPROPERTIES returns Nil for temp view. cc @maropu @viirya

[SparkQA]

Test build #126446 has finished for PR 29127 at commit 933dc28.

• This patch fails Spark unit tests.
• This patch merges cleanly.
• This patch adds no public classes.

[viirya]

Now I don't have a strong opinion. Users can't create temp view with properties and it seems fine if SHOW TBLPROPERTIES returns Nil for temp view. cc @maropu @viirya

Sounds ok too.

[imback82]

Yes, I agree. I will close this for now. Thanks!

[maropu]

Now I don't have a strong opinion. Users can't create temp view with properties and it seems fine if SHOW TBLPROPERTIES returns Nil for temp view. cc @maropu @viirya

I missed that.. yea, the decision sounds okay to me, too. Anyway, thanks for the work, @imback82 !