Skip to content

[SPARK-32018][SQL][2.4] UnsafeRow.setDecimal should set null with overflowed value #29141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cloud-fan wants to merge 1 commit into from
Closed

[SPARK-32018][SQL][2.4] UnsafeRow.setDecimal should set null with overflowed value #29141

cloud-fan wants to merge 1 commit into from

Conversation

@cloud-fan
Copy link
Contributor

@cloud-fan cloud-fan commented Jul 17, 2020

backport #29125

@cloud-fan
[SPARK-32018][SQL][3.0] UnsafeRow.setDecimal should set null with ove…
3210002 
…rflowed value

partially backport apache#29026

Closes apache#29125 from cloud-fan/backport.

Authored-by: Wenchen Fan <wenchen@databricks.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@cloud-fan
Copy link
Contributor Author

cloud-fan commented Jul 17, 2020

cc @dongjoon-hyun

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jul 17, 2020

Thank you, @cloud-fan !

@SparkQA
Copy link

SparkQA commented Jul 17, 2020

Test build #126030 has finished for PR 29141 at commit 3210002.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jul 17, 2020

Retest this please.

@SparkQA
Copy link

SparkQA commented Jul 17, 2020

Test build #126037 has finished for PR 29141 at commit 3210002.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

dongjoon-hyun
dongjoon-hyun approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to branch-2.4.

dongjoon-hyun pushed a commit that referenced this pull request Jul 17, 2020
@cloud-fan @dongjoon-hyun
[SPARK-32018][SQL][2.4] UnsafeRow.setDecimal should set null with ove…
afdad0e 
…rflowed value

backport #29125

Closes #29141 from cloud-fan/backport.

Authored-by: Wenchen Fan <wenchen@databricks.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@cloud-fan
Copy link
Contributor Author

cloud-fan commented Aug 17, 2020 •
edited
Loading

I'm reverting it from 2.4, see #29450 (comment)

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Aug 17, 2020

Got it. I understand the situation. Thank you for the decision, @cloud-fan .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees

No one assigned

Labels

SQL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cloud-fan @dongjoon-hyun @SparkQA