-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-32409][DOC] Document dependency between spark.metrics.staticSources.enabled and JVMSource registration #29203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can one of the admins verify this patch? |
|
Hi, SPARK-32409 is this issue which is not merged yet, @LucaCanali .
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a partial revert of another your previous commit, #22279, two year ago, isn't it?
[SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens in YARN applicationMaster after this PR?
|
@dongjoon-hyun thank you very much for your quick reply on this and the comments. I can see a couple of options to move this forward:
Any thoughts? |
|
I prefer the second approach, @LucaCanali . |
a485e28 to
8988173
Compare
OK for me, @dongjoon-hyun thanks for looking at it. |
…urces.enabled and JVMSource registration ### What changes were proposed in this pull request? Document the dependency between the config `spark.metrics.staticSources.enabled` and JVMSource registration. ### Why are the changes needed? This PT just documents the dependency between config `spark.metrics.staticSources.enabled` and JVM source registration. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually tested. Closes #29203 from LucaCanali/bugJVMMetricsRegistration. Authored-by: Luca Canali <luca.canali@cern.ch> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 99f50c6) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
Thank you, @LucaCanali . Merged to master/3.0. |
What changes were proposed in this pull request?
Document the dependency between the config
spark.metrics.staticSources.enabledand JVMSource registration.Why are the changes needed?
This PT just documents the dependency between config
spark.metrics.staticSources.enabledand JVM source registration.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually tested.