[SPARK-4095][YARN][Minor]extract val isLaunchingDriver in ClientBase

[WangTaoTheTonic]

Instead of checking if args.userClass is null repeatedly, we extract it to an global val as in ApplicationMaster.

[SparkQA]

Test build #22278 has started for PR 2954 at commit 13bda20.

• This patch merges cleanly.

[SparkQA]

Test build #22278 has finished for PR 2954 at commit 13bda20.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/22278/
Test PASSed.

[tgravescs]

@WangTaoTheTonic I would rather not see pull requests that don't really add any value. I realize this is cleanup, but I would rather see these included in something more meaningful. For instance if you had to add one more reference to isLauncherDriver or something like that. Otherwise this just adds a lot of overhead of having to review and test, etc.. I'll commit this one but please keep that in mind for future prs.

[WangTaoTheTonic]

OK I see.

发自我的 iPhone

在 2014年10月28日，21:51，Tom Graves notifications@github.com 写道：

@WangTaoTheTonic I would rather not see pull requests that don't really add any value. I realize this is cleanup, but I would rather see these included in something more meaningful. For instance if you had to add one more reference to isLauncherDriver or something like that. Otherwise this just adds a lot of overhead of having to review and test, etc.. I'll commit this one but please keep that in mind for future prs.

—
Reply to this email directly or view it on GitHub.