Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Oct 19, 2020

What changes were proposed in this pull request?

This PR proposes to use fail_if_no_tests option at action-surefire-report plugin, see also ScaCap/action-surefire-report#29.

#29946 introduced the manual skipping in Apache Spark itself. After that, the plugin introduced the feature. Now, this PR reverts #29946 and enable that option.

Why are the changes needed?

To remove manual skipping and avoid maintenance cost.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

I will push a commit to show in this PR because this change is specific to GitHub Actions: https://github.com/apache/spark/actions/runs/314900487

@SparkQA

This comment has been minimized.

@SparkQA

This comment has been minimized.

@SparkQA

This comment has been minimized.

@SparkQA

This comment has been minimized.

@SparkQA

This comment has been minimized.

@SparkQA

This comment has been minimized.

@SparkQA
Copy link

SparkQA commented Oct 19, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34595/

@SparkQA
Copy link

SparkQA commented Oct 19, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34597/

@SparkQA
Copy link

SparkQA commented Oct 19, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34598/

@SparkQA
Copy link

SparkQA commented Oct 19, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34595/

@SparkQA
Copy link

SparkQA commented Oct 19, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34597/

@SparkQA
Copy link

SparkQA commented Oct 19, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34598/

@HyukjinKwon
Copy link
Member Author

Oh, looks like now it fails to download when artifacts are not uploaded (dawidd6/action-download-artifact#32). I am just going to revert the original PR alone.

@SparkQA
Copy link

SparkQA commented Oct 19, 2020

Test build #129992 has finished for PR 30091 at commit db9563f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon HyukjinKwon deleted the SPARK-33180 branch December 7, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants