[SPARK-33480][SQL][FOLLOWUP] do not expose user data in error message #30653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
changed the title
Contributor
Author
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
dongjoon-hyun
approved these changes
Dec 7, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. (Pending CIs)
|
Test build #132380 has finished for PR 30653 at commit
|
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 7, 2020
### What changes were proposed in this pull request? This is a followup of #30412. This PR updates the error message of char/varchar table insertion length check, to not expose user data. ### Why are the changes needed? This is risky to expose user data in the error message, especially the string data, as it may contain sensitive data. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? updated tests Closes #30653 from cloud-fan/minor2. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit c0874ba) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Merged to master/3.1. |
Member
|
late lgtm |
Member
|
LGTM, nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #30412. This PR updates the error message of char/varchar table insertion length check, to not expose user data.
Why are the changes needed?
This is risky to expose user data in the error message, especially the string data, as it may contain sensitive data.
Does this PR introduce any user-facing change?
no
How was this patch tested?
updated tests