[SPARK-33742][SQL][3.1] Throw PartitionsAlreadyExistException from HiveExternalCatalog.createPartitions() #30729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernalCatalog.createPartitions() Throw `PartitionsAlreadyExistException` from `createPartitions()` in Hive external catalog when a partition exists. Currently, `HiveExternalCatalog.createPartitions()` throws `AlreadyExistsException` wrapped by `AnalysisException`. In the PR, I propose to catch `AlreadyExistsException` in `HiveClientImpl` and replace it by `PartitionsAlreadyExistException`. The behaviour of Hive external catalog deviates from V1/V2 in-memory catalogs that throw `PartitionsAlreadyExistException`. To improve user experience with Spark SQL, it would be better to throw the same exception. Yes By running existing test suites: ``` $ build/sbt -Phive-2.3 -Phive-thriftserver "test:testOnly *AlterTableAddPartitionSuite" ``` Closes apache#30711 from MaxGekk/hive-partition-exception. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit fab2995) Signed-off-by: Max Gekk <max.gekk@gmail.com>
|
Test build #132647 has finished for PR 30729 at commit
|
|
Kubernetes integration test starting |
Member
Author
|
jenkins, retest this, please |
|
Kubernetes integration test status failure |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #132653 has finished for PR 30729 at commit
|
dongjoon-hyun
approved these changes
Dec 11, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thanks, @MaxGekk .
Merged to branch-3.1.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Dec 11, 2020
…veExternalCatalog.createPartitions() ### What changes were proposed in this pull request? Throw `PartitionsAlreadyExistException` from `createPartitions()` in Hive external catalog when a partition exists. Currently, `HiveExternalCatalog.createPartitions()` throws `AlreadyExistsException` wrapped by `AnalysisException`. In the PR, I propose to catch `AlreadyExistsException` in `HiveClientImpl` and replace it by `PartitionsAlreadyExistException`. ### Why are the changes needed? The behaviour of Hive external catalog deviates from V1/V2 in-memory catalogs that throw `PartitionsAlreadyExistException`. To improve user experience with Spark SQL, it would be better to throw the same exception. ### Does this PR introduce _any_ user-facing change? Yes ### How was this patch tested? By running existing test suites: ``` $ build/sbt -Phive -Phive-thriftserver "hive/test:testOnly org.apache.spark.sql.hive.client.VersionsSuite" $ build/sbt -Phive -Phive-thriftserver "hive/test:testOnly org.apache.spark.sql.hive.execution.HiveDDLSuite" ``` Authored-by: Max Gekk <max.gekkgmail.com> Signed-off-by: Dongjoon Hyun <dongjoonapache.org> (cherry picked from commit fab2995) Signed-off-by: Max Gekk <max.gekkgmail.com> Closes #30729 from MaxGekk/hive-partition-exception-3.1. Authored-by: Max Gekk <max.gekk@gmail.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Throw
PartitionsAlreadyExistExceptionfromcreatePartitions()in Hive external catalog when a partition exists. Currently,HiveExternalCatalog.createPartitions()throwsAlreadyExistsExceptionwrapped byAnalysisException.In the PR, I propose to catch
AlreadyExistsExceptioninHiveClientImpland replace it byPartitionsAlreadyExistException.Why are the changes needed?
The behaviour of Hive external catalog deviates from V1/V2 in-memory catalogs that throw
PartitionsAlreadyExistException. To improve user experience with Spark SQL, it would be better to throw the same exception.Does this PR introduce any user-facing change?
Yes
How was this patch tested?
By running existing test suites:
Authored-by: Max Gekk max.gekk@gmail.com
Signed-off-by: Dongjoon Hyun dongjoon@apache.org
(cherry picked from commit fab2995)
Signed-off-by: Max Gekk max.gekk@gmail.com