[Streaming][Minor]Replace some 'if-else' in Clock #3088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace some 'if-else' statement by math.min and math.max in Clock.scala
Contributor
|
Hey @SaintBacchus Please make a JIRA for this update the title with the JIRA number (see other PRs) |
Contributor
|
Jenkins, this is ok to test. |
|
Test build #23185 has finished for PR 3088 at commit
|
Contributor
|
This looks good to me. Please add the JIRA in the title, and I can merge this after that. |
Contributor
|
Since this is a small change, i am merging this. |
asfgit
pushed a commit
that referenced
this pull request
Nov 11, 2014
Replace some 'if-else' statement by math.min and math.max in Clock.scala Author: huangzhaowei <carlmartinmax@gmail.com> Closes #3088 from SaintBacchus/StreamingClock and squashes the following commits: 7b7f8e7 [huangzhaowei] [Streaming][Minor]Replace some 'if-else' in Clock (cherry picked from commit 6e03de3) Signed-off-by: Tathagata Das <tathagata.das1565@gmail.com>
Contributor
Author
|
@tdas Thx for merging it. I consider it as a small improvement and will always make a jira next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace some 'if-else' statement by math.min and math.max in Clock.scala