[SPARK-33996][BUILD] Upgrade checkstyle plugins. #31019
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhyun
changed the title
dongjoon-hyun
approved these changes
Jan 4, 2021
There was a problem hiding this comment.
+1, LGTM. Thank you, @williamhyun .
GitHub Action linter job passed. Merged to master for Apache Spark 3.2.0.
HyukjinKwon
added a commit
that referenced
this pull request
Jul 5, 2021
… to Maven's ### What changes were proposed in this pull request? This PR is a followup of #31019 that forgot to update SBT's to match. ### Why are the changes needed? To use the same version in both Maven and SBT. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI should test them. Closes #33207 from HyukjinKwon/SPARK-33996. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon
added a commit
that referenced
this pull request
Jul 5, 2021
… to Maven's ### What changes were proposed in this pull request? This PR is a followup of #31019 that forgot to update SBT's to match. ### Why are the changes needed? To use the same version in both Maven and SBT. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CI should test them. Closes #33207 from HyukjinKwon/SPARK-33996. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org> (cherry picked from commit 2fe6c94) Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to upgrade
checkstyleMaven plugins and its dependency,com.puppycrawl.tools:checkstyle.Why are the changes needed?
The changes are needed to support Java 14+ better.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CI.