Skip to content

Conversation

@imback82
Copy link
Contributor

@imback82 imback82 commented Jan 5, 2021

What changes were proposed in this pull request?

After #30287, runShowTablesSql() in DataSourceV2SQLSuite.scala is no longer used. This PR removes the unused method.

Why are the changes needed?

To remove unused method.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing test.

@github-actions github-actions bot added the SQL label Jan 5, 2021
@SparkQA
Copy link

SparkQA commented Jan 5, 2021

Test build #133634 has finished for PR 31022 at commit ff49134.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jan 5, 2021

@imback82 . Please use a different JIRA ID because we already have rc1 tag. This needs a new independent JIRA ID because this cannot go to branch-3.1 in general.

a commit two month ago is too old to make a followup.

@imback82 imback82 changed the title [SPARK-33382][SQL][TESTS][FOLLOWUP] Remove unused runShowTablesSql() in DataSourceV2SQLSuite.scala [SPARK-34001][SQL][TESTS][FOLLOWUP] Remove unused runShowTablesSql() in DataSourceV2SQLSuite.scala Jan 5, 2021
@imback82 imback82 changed the title [SPARK-34001][SQL][TESTS][FOLLOWUP] Remove unused runShowTablesSql() in DataSourceV2SQLSuite.scala [SPARK-34001][SQL][TESTS] Remove unused runShowTablesSql() in DataSourceV2SQLSuite.scala Jan 5, 2021
@imback82
Copy link
Contributor Author

imback82 commented Jan 5, 2021

Ah OK. Created a new JIRA ID. Thanks @dongjoon-hyun!

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @imback82 .

+1, LGTM. Merged to master for Apache Spark 3.2.0.

@SparkQA
Copy link

SparkQA commented Jan 5, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38223/

@SparkQA
Copy link

SparkQA commented Jan 5, 2021

Test build #133645 has finished for PR 31022 at commit b89813e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jan 5, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38223/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants