Skip to content

[SPARK-4304] [PySpark] Fix sort on empty RDD (1.0 branch) #3163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davies wants to merge 1 commit into from
Closed

[SPARK-4304] [PySpark] Fix sort on empty RDD (1.0 branch) #3163

davies wants to merge 1 commit into from

Conversation

@davies
Copy link
Contributor

@davies davies commented Nov 8, 2014

This PR fix sortBy()/sortByKey() on empty RDD.

This should be back ported into 1.0

@SparkQA
Copy link

SparkQA commented Nov 8, 2014

Test build #23082 has started for PR 3163 at commit 9be984f.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 8, 2014

Test build #23082 has finished for PR 3163 at commit 9be984f.

  • This patch fails some tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 8, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23082/
Test FAILed.

@JoshRosen
Copy link
Contributor

JoshRosen commented Nov 8, 2014

LGTM; it looks like the test failure is due to some unrelated YARN build-breakage in the 1.0 backports branch, but I've looked at this pretty carefully and everything seems to check out, so I'm going to merge this. Thanks!

@JoshRosen
Copy link
Contributor

JoshRosen commented Nov 8, 2014

(BTW, do you mind closing this since GitHub can't auto-close PRs against backport branches? Thanks!)

asfgit pushed a commit that referenced this pull request Nov 8, 2014
@JoshRosen
[SPARK-4304] [PySpark] Fix sort on empty RDD (1.0 branch)
d4aed26 
This PR fix sortBy()/sortByKey() on empty RDD.

This should be back ported into 1.0

Author: Davies Liu <davies@databricks.com>

Closes #3163 from davies/fix_sort_1.0 and squashes the following commits:

9be984f [Davies Liu] fix sort on empty RDD
@davies
Copy link
Contributor Author

davies commented Nov 8, 2014

merged, thanks!

@davies davies closed this Nov 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davies @SparkQA @AmplabJenkins @JoshRosen