[SPARK-34152][SQL][FOLLOWUP] Do not uncache the temp view if it doesn't exist #31650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
imback82
approved these changes
Feb 25, 2021
Contributor
imback82
left a comment
imback82
left a comment
There was a problem hiding this comment.
LGTM (pending tests), thanks @cloud-fan for fixing this!
viirya
approved these changes
Feb 25, 2021
|
Test build #135470 has finished for PR 31650 at commit
|
dongjoon-hyun
approved these changes
Feb 25, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
Member
|
Thank you, @cloud-fan and all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes a mistake in #31273. When CREATE OR REPLACE a temp view, we need to uncache the to-be-replaced existing temp view. However, we shouldn't uncache if there is no existing temp view.
This doesn't cause real issues because the uncache action is failure-safe. But it produces a lot of warning messages.
Why are the changes needed?
Avoid unnecessary warning logs.
Does this PR introduce any user-facing change?
no
How was this patch tested?
manually run tests and check the warning messages.