[SPARK-34775][SQL] Push down limit through window when partitionSpec is not empty #31926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Will add new Unit test later |
Contributor
Author
|
cc @wangyum |
|
Can one of the admins verify this patch? |
wangyum
requested changes
Mar 30, 2021
Member
wangyum
left a comment
wangyum
left a comment
There was a problem hiding this comment.
Could you add more test cases to LimitPushdownThroughWindowSuite?
Member
|
It seems Impala supports this optimization: |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup from #31691. Push down limit through Window when the partitionSpec of all window functions is not empty and the same order is used.
What changes were proposed in this pull request?
Push down limit through Window when the partitionSpec of all window functions is not empty
Why are the changes needed?
Improve query performance.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.