[HOTFIX]: Fix maven build missing some class

[witgo]

The bug was caused by #3159

[witgo]

cc @pwendell @ScrapCodes @srowen

[SparkQA]

Test build #23268 has started for PR 3228 at commit 7ea18a7.

• This patch merges cleanly.

[srowen]

+1 looks correct to me, as other occurrences of this profile are activated by default in modules. It would also explain the behavior we see.

[SparkQA]

Test build #23268 has finished for PR 3228 at commit 7ea18a7.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23268/
Test PASSed.

[srowen]

See SPARK-4375 now. There is more to fixing it than this it seems.

[ScrapCodes]

Currently there is no way around not passing -Pscala-2.10/-Pscala-2.11 for maven users. We can either document this, or I am not sure if there is another way.

[witgo]

How about the following?

 <profile>
      <id>scala-2.10</id>
      <activation>
        <property>
          <name>scala.version</name>
          <value>2.10.4</value>
        </property>
      </activation>
      <properties>
        <scala.binary.version>2.10</scala.binary.version>
        <jline.version>${scala.version}</jline.version>
        <jline.groupid>org.scala-lang</jline.groupid>
      </properties>
      <modules>
        <module>external/kafka</module>
      </modules>
    </profile>
   <profile>
      <id>scala-2.11</id>
      <activation>
        <property>
          <name>scala.version</name>
          <value>2.11.2</value>
        </property>
      </activation>
      <properties>
        <scala.binary.version>2.11</scala.binary.version>
        <jline.version>2.12</jline.version>
        <jline.groupid>jline</jline.groupid>
      </properties>
    </profile>

[sryza]

That still requires the user to set "scala.version", right?

[witgo]

Yes, it seems to work.It seems that the user must explicitly set scala.version.