[SPARK-35230][SQL] Move custom metric classes to proper package #32348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
commented
Apr 26, 2021
| * Returns the name of custom metric. | ||
| */ | ||
| String name(); | ||
| /** |
Member
Author
There was a problem hiding this comment.
indentation was wrong. Fixed them together.
Member
Author
|
cc @cloud-fan |
|
Kubernetes integration test starting |
cloud-fan
approved these changes
Apr 26, 2021
|
Kubernetes integration test status failure |
|
Test build #137944 has finished for PR 32348 at commit
|
dongjoon-hyun
approved these changes
Apr 26, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @viirya and @cloud-fan .
Merged to master.
Member
Author
|
Thank you @dongjoon-hyun and @cloud-fan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch moves DS v2 custom metric classes to
org.apache.spark.sql.connector.metricpackage. MovingCustomAvgMetricandCustomSumMetricto above package and make them as public java abstract class too.Why are the changes needed?
CustomAvgMetricandCustomSumMetricshould be public APIs for developers to extend. As there are a few metric classes, we should put them together in one package.Does this PR introduce any user-facing change?
No, dev only and they are not released yet.
How was this patch tested?
Unit tests.