[SPARK-35276][CORE] Calculate checksum for shuffle data and write as checksum file #32401
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.shuffle.checksum; | ||
Ngone51 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| import java.util.zip.Adler32; | ||
| import java.util.zip.CRC32; | ||
| import java.util.zip.Checksum; | ||
|
|
||
| import org.apache.spark.SparkConf; | ||
| import org.apache.spark.SparkException; | ||
| import org.apache.spark.annotation.Private; | ||
| import org.apache.spark.internal.config.package$; | ||
| import org.apache.spark.storage.ShuffleChecksumBlockId; | ||
|
|
||
| /** | ||
| * A set of utility functions for the shuffle checksum. | ||
| */ | ||
| @Private | ||
| public class ShuffleChecksumHelper { | ||
|
||
|
|
||
| /** Used when the checksum is disabled for shuffle. */ | ||
| private static final Checksum[] EMPTY_CHECKSUM = new Checksum[0]; | ||
| public static final long[] EMPTY_CHECKSUM_VALUE = new long[0]; | ||
|
|
||
| public static boolean isShuffleChecksumEnabled(SparkConf conf) { | ||
| return (boolean) conf.get(package$.MODULE$.SHUFFLE_CHECKSUM_ENABLED()); | ||
| } | ||
|
|
||
| public static Checksum[] createPartitionChecksumsIfEnabled(int numPartitions, SparkConf conf) | ||
| throws SparkException { | ||
| if (!isShuffleChecksumEnabled(conf)) { | ||
| return EMPTY_CHECKSUM; | ||
| } | ||
|
|
||
| String checksumAlgo = shuffleChecksumAlgorithm(conf); | ||
| return getChecksumByAlgorithm(numPartitions, checksumAlgo); | ||
| } | ||
|
|
||
| private static Checksum[] getChecksumByAlgorithm(int num, String algorithm) | ||
| throws SparkException { | ||
| Checksum[] checksums; | ||
| switch (algorithm) { | ||
| case "ADLER32": | ||
| checksums = new Adler32[num]; | ||
| for (int i = 0; i < num; i ++) { | ||
| checksums[i] = new Adler32(); | ||
| } | ||
| return checksums; | ||
|
|
||
| case "CRC32": | ||
| checksums = new CRC32[num]; | ||
| for (int i = 0; i < num; i ++) { | ||
| checksums[i] = new CRC32(); | ||
| } | ||
| return checksums; | ||
|
|
||
| default: | ||
| throw new SparkException("Unsupported shuffle checksum algorithm: " + algorithm); | ||
| } | ||
| } | ||
|
|
||
| public static long[] getChecksumValues(Checksum[] partitionChecksums) { | ||
mridulm marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| int numPartitions = partitionChecksums.length; | ||
| long[] checksumValues = new long[numPartitions]; | ||
| for (int i = 0; i < numPartitions; i ++) { | ||
| checksumValues[i] = partitionChecksums[i].getValue(); | ||
| } | ||
| return checksumValues; | ||
| } | ||
|
|
||
| public static String shuffleChecksumAlgorithm(SparkConf conf) { | ||
| return conf.get(package$.MODULE$.SHUFFLE_CHECKSUM_ALGORITHM()); | ||
| } | ||
|
|
||
| public static Checksum getChecksumByFileExtension(String fileName) throws SparkException { | ||
| int index = fileName.lastIndexOf("."); | ||
| String algorithm = fileName.substring(index + 1); | ||
| return getChecksumByAlgorithm(1, algorithm)[0]; | ||
| } | ||
|
|
||
| public static String getChecksumFileName(ShuffleChecksumBlockId blockId, SparkConf conf) { | ||
| // append the shuffle checksum algorithm as the file extension | ||
| return String.format("%s.%s", blockId.name(), shuffleChecksumAlgorithm(conf)); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I don't think the current shuffle API provides enough abstraction to do checksum. I'm OK with this change as the shuffle API is still private, but we should revisit the shuffle API later, so that checksum can be done at the shuffle implementation side.
The current issue I see is, Spark writes local spill files and then asks the shuffle implementation to "transfer" the spill files. Then Spark has to do checksum by itself during spill file writing, to reduce the perf overhead.
We can discuss it later.