[SPARK-32792][SQL][FOLLOWUP] Fix conflict with SPARK-34661 #32568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you! |
| FilterApi.lt(longColumn(n), decimalToInt64(v.asInstanceOf[JBigDecimal])) | ||
| case ParquetSchemaType(_: DecimalLogicalTypeAnnotation, FIXED_LEN_BYTE_ARRAY, length) | ||
| if pushDownDecimal => | ||
| if pushDownDecimal => |
Member
There was a problem hiding this comment.
Although this is HOTFIX, okay.
wangyum
changed the title
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
May 17, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. I also verified this manually.
Member
|
Thank you so much, @wangyum and @HyukjinKwon . Merged to master to recover |
Member
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This fixes the compilation error due to the logical conflicts between #31776 and #29642 .
Why are the changes needed?
To recover compilation.
Does this PR introduce any user-facing change?
No.
How was this patch tested?