Skip to content

[SPARK-4422][MLLIB]In some cases, Vectors.fromBreeze get wrong results. #3281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
witgo wants to merge 3 commits into from
Closed

[SPARK-4422][MLLIB]In some cases, Vectors.fromBreeze get wrong results. #3281

witgo wants to merge 3 commits into from

Conversation

@witgo
Copy link
Contributor

@witgo witgo commented Nov 15, 2014

cc @mengxr

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23415 has started for PR 3281 at commit 7a10123.

  • This patch merges cleanly.

mengxr
mengxr reviewed Nov 15, 2014
View reviewed changes
mllib/src/test/scala/org/apache/spark/mllib/linalg/VectorsSuite.scala Outdated
Copy link
Contributor

@mengxr mengxr Nov 15, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the same group as org.scalatest.FunSuite because both are 3rd-party imports.

@mengxr
Copy link
Contributor

mengxr commented Nov 15, 2014

Thanks! LGTM except the imports should be organized.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23417 has started for PR 3281 at commit 50783bd.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23419 has started for PR 3281 at commit 5f1fa5e.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23415 has finished for PR 3281 at commit 7a10123.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 15, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23415/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23417 has finished for PR 3281 at commit 50783bd.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 15, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23417/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Nov 15, 2014

Test build #23419 has finished for PR 3281 at commit 5f1fa5e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 15, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23419/
Test PASSed.

@mengxr
Copy link
Contributor

mengxr commented Nov 17, 2014

Merged into master and branch-1.2. Thanks!

asfgit pushed a commit that referenced this pull request Nov 17, 2014
@witgo @mengxr
[SPARK-4422][MLLIB]In some cases, Vectors.fromBreeze get wrong results.
f3b93c1 
cc mengxr

Author: GuoQiang Li <witgo@qq.com>

Closes #3281 from witgo/SPARK-4422 and squashes the following commits:

5f1fa5e [GuoQiang Li] import order
50783bd [GuoQiang Li] review commits
7a10123 [GuoQiang Li] In some cases, Vectors.fromBreeze get wrong results.

(cherry picked from commit 5168c6c)
Signed-off-by: Xiangrui Meng <meng@databricks.com>
@asfgit asfgit closed this in 5168c6c Nov 17, 2014
@witgo witgo deleted the SPARK-4422 branch November 17, 2014 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@witgo @SparkQA @mengxr @AmplabJenkins