Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jun 29, 2021

What changes were proposed in this pull request?

This PR aims to update JDBC v2 integration suite by adding catalogName.

Why are the changes needed?

To recover the integration test suite.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the GitHub Action.

@cloud-fan
Copy link
Contributor

thanks for fixing it!

BTW is there a way to capture it in PR builders? Otherwise, it's too easy to forget checking...

@dongjoon-hyun
Copy link
Member Author

This seems to disabled by ENABLE_DOCKER_INTEGRATION_TESTS intentionally and designed to be turned on docker module change only at the original commit (2de19e4).

cc @sarutak and @HyukjinKwon .

@dongjoon-hyun
Copy link
Member Author

I'll make a followup PR for SPARK-35483 to enable it for SQL part change, too.

@sarutak
Copy link
Member

sarutak commented Jun 29, 2021

@dongjoon-hyun
I think It's because docker-integration-tests don't depend on sql module in dev/sparktestsupport/modules.py.

We intentionally let the dependency empty after the discussion.
If it's better to depends on sql module, I'll fix it.

@dongjoon-hyun
Copy link
Member Author

@HyukjinKwon HyukjinKwon changed the title [SPARK-34302][SQL][TEST] Update jdbc.v2.*IntegrationSuite [SPARK-34302][SQL][TESTS] Update jdbc.v2.*IntegrationSuite Jun 29, 2021
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-34302][SQL][TESTS] Update jdbc.v2.*IntegrationSuite [SPARK-34302][FOLLOWUP][SQL][TESTS] Update jdbc.v2.*IntegrationSuite Jun 29, 2021
@dongjoon-hyun
Copy link
Member Author

Docker integration test passed.

Merged to master. Thank you, @cloud-fan , @sarutak , @HyukjinKwon .

@dongjoon-hyun dongjoon-hyun deleted the SPARK-34302 branch June 29, 2021 06:02
@imback82
Copy link
Contributor

Thanks @dongjoon-hyun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants