-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPARK-35980][CORE] ThreadAudit logs whether thread is daemon #33178
Conversation
cc @gaborgsomogyi can you take a quick look when you find some time? |
ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me
Kubernetes integration test starting |
Kubernetes integration test status success |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@HyukjinKwon I agree, it's a good addition. |
Test build #140575 has finished for PR 33178 at commit
|
Seems like unrelated: |
retest this please |
Filed SPARK-35993 to track the issue. |
Kubernetes integration test starting |
Kubernetes integration test starting |
Kubernetes integration test status success |
Kubernetes integration test status success |
Test build #140584 has finished for PR 33178 at commit
|
Thanks for the quick reviews! |
Can one of the admins verify this patch? |
Merged to master. |
What changes were proposed in this pull request?
Add
daemon={true|false}
to the POSSIBLE THREAD LEAK IN SUITE warning printed by test framework.Why are the changes needed?
This is to slightly accelerate interpretation of that warning, since non-daemon threads can block the process from exiting and are likely to be problematic.
Only affects test code.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manually ran some tests, inspected the output log line.