Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-35980][CORE] ThreadAudit logs whether thread is daemon #33178

Closed
wants to merge 3 commits into from

Conversation

timarmstrong
Copy link
Contributor

What changes were proposed in this pull request?

Add daemon={true|false} to the POSSIBLE THREAD LEAK IN SUITE warning printed by test framework.

Why are the changes needed?

This is to slightly accelerate interpretation of that warning, since non-daemon threads can block the process from exiting and are likely to be problematic.

Only affects test code.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Manually ran some tests, inspected the output log line.

@github-actions github-actions bot added the CORE label Jul 1, 2021
@HyukjinKwon
Copy link
Member

cc @gaborgsomogyi can you take a quick look when you find some time?

@HyukjinKwon
Copy link
Member

ok to test

Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@SparkQA
Copy link

SparkQA commented Jul 2, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45086/

@SparkQA
Copy link

SparkQA commented Jul 2, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45086/

Copy link
Contributor

@gaborgsomogyi gaborgsomogyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gaborgsomogyi
Copy link
Contributor

@HyukjinKwon I agree, it's a good addition.

@SparkQA
Copy link

SparkQA commented Jul 2, 2021

Test build #140575 has finished for PR 33178 at commit 6a3ccd1.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gaborgsomogyi
Copy link
Contributor

Seems like unrelated:
java.io.FileNotFoundException: File /home/jenkins/workspace/SparkPullRequestBuilder@2/target/tmp/spark-21674620-ac83-4ad3-a153-5a7adf909244/20.zip does not exist

@gaborgsomogyi
Copy link
Contributor

retest this please

@gaborgsomogyi
Copy link
Contributor

Filed SPARK-35993 to track the issue.

@SparkQA
Copy link

SparkQA commented Jul 2, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45095/

@SparkQA
Copy link

SparkQA commented Jul 2, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45096/

@SparkQA
Copy link

SparkQA commented Jul 2, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45095/

@SparkQA
Copy link

SparkQA commented Jul 2, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45096/

@SparkQA
Copy link

SparkQA commented Jul 2, 2021

Test build #140584 has finished for PR 33178 at commit 6a3ccd1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@timarmstrong
Copy link
Contributor Author

Thanks for the quick reviews!

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants