Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-36013][BUILD] Upgrade Dropwizard Metrics to 4.2.2 #33209

Closed
wants to merge 1 commit into from

Conversation

sarutak
Copy link
Member

@sarutak sarutak commented Jul 5, 2021

What changes were proposed in this pull request?

This PR aims to upgrade Dropwizard Metrics from 4.2.0 to 4.2.2.

Why are the changes needed?

Dropwizard 4.2.1 fixes a bug related to JMXReporter but 4.2.1 also contains a bug. so upgrading to 4.2.2 seems better.
https://github.com/dropwizard/metrics/releases/tag/v4.2.1
https://github.com/dropwizard/metrics/releases/tag/v4.2.2

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

@github-actions github-actions bot added the BUILD label Jul 5, 2021
@@ -147,7 +147,7 @@
If you changes codahale.metrics.version, you also need to change
the link to metrics.dropwizard.io in docs/monitoring.md.
-->
<codahale.metrics.version>4.2.0</codahale.metrics.version>
<codahale.metrics.version>4.2.2</codahale.metrics.version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URL for Dropwizard Metrics is still https://metrics.dropwizard.io/4.2.0/ so the document is not changed.

@SparkQA
Copy link

SparkQA commented Jul 5, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45143/

@SparkQA
Copy link

SparkQA commented Jul 5, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45143/

@SparkQA
Copy link

SparkQA commented Jul 5, 2021

Test build #140630 has finished for PR 33209 at commit 20ff0f6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants