Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-36257][SQL] Updated the version of TimestampNTZ related changes as 3.3.0 #33478

Closed
wants to merge 2 commits into from

Conversation

gengliangwang
Copy link
Member

What changes were proposed in this pull request?

As we decided to release TimestampNTZ type in Spark 3.3, we should update the versions of TimestampNTZ related changes as 3.3.0.

Why are the changes needed?

Correct the versions in documentation/code comment.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing UT

@gengliangwang
Copy link
Member Author

cc @beliefer as well

@SparkQA
Copy link

SparkQA commented Jul 22, 2021

Test build #141476 has finished for PR 33478 at commit 343383c.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gengliangwang
Copy link
Member Author

jenkins, retest this please

Copy link
Contributor

@beliefer beliefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkQA
Copy link

SparkQA commented Jul 22, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45994/

Copy link
Member

@MaxGekk MaxGekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

* @since 3.2.0
*/
def localtimestamp(): Column = withExpr { LocalTimestamp() }

@SparkQA
Copy link

SparkQA commented Jul 22, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45994/

@SparkQA
Copy link

SparkQA commented Jul 22, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45996/

@gengliangwang
Copy link
Member Author

@MaxGekk Thanks, I have updated the code.

@SparkQA
Copy link

SparkQA commented Jul 22, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46004/

@SparkQA
Copy link

SparkQA commented Jul 22, 2021

Test build #141479 has finished for PR 33478 at commit 343383c.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@gengliangwang
Copy link
Member Author

Merging to master

@SparkQA
Copy link

SparkQA commented Jul 22, 2021

Test build #141486 has finished for PR 33478 at commit 6ded562.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants