-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-36512][UI][TESTS] Fix UISeleniumSuite in sql/hive-thriftserver #33741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #142465 has finished for PR 33741 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
This comment has been minimized.
This comment has been minimized.
|
cc @gengliangwang FYI |
|
cc: @dongjoon-hyun too. |
|
@sarutak sorry for the late reply. It seems that the test is ignored. Shall we enable it in this PR? |
|
@gengliangwang Thank you for the reply. The reason the test was ignored seems flakiness (#6345). |
|
If we are not going to enable it, it doesn't make sense to fix it... |
|
Test build #142618 has finished for PR 33741 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Refer to this link for build results (access rights to CI server needed): |
|
Thanks, merging to master |
…ation in UI by config ### What changes were proposed in this pull request? This PR adds a test for SPARK-36400 (#33743). ### Why are the changes needed? SPARK-36512 (#33741) was fixed so we can add this test now. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New test. Closes #33885 from sarutak/add-reduction-test. Authored-by: Kousuke Saruta <sarutak@oss.nttdata.com> Signed-off-by: Kousuke Saruta <sarutak@oss.nttdata.com>
### What changes were proposed in this pull request? This PR fixes an issue that `UISeleniumSuite` in `sql/hive-thriftserver` doesn't work even though the ignored test is enabled due to the following two reasons. (1) The suite waits for thriftserver starting up by reading a startup message from stdin but the expected message is never read. (2) The URL and CSS selector for test are wrong. To resolve (1), this PR adopt the way that `HiveThriftServer2Suite` does. https://github.com/apache/spark/blob/3f8ec0dae4ddfd7ee55370dad5d44d03a9f10387/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala#L1222-L1248 This PR also enables the ignored test. Let's disable it again in the following PR if it's still flaky. ### Why are the changes needed? Bug fix. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? CIs. Closes apache#33741 from sarutak/fix-thrift-uiseleniumsuite. Authored-by: Kousuke Saruta <sarutak@oss.nttdata.com> Signed-off-by: Gengliang Wang <gengliang@apache.org>
What changes were proposed in this pull request?
This PR fixes an issue that
UISeleniumSuiteinsql/hive-thriftserverdoesn't work even though the ignored test is enabled due to the following two reasons.(1) The suite waits for thriftserver starting up by reading a startup message from stdin but the expected message is never read.
(2) The URL and CSS selector for test are wrong.
To resolve (1), this PR adopt the way that
HiveThriftServer2Suitedoes.spark/sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
Lines 1222 to 1248 in 3f8ec0d
This PR also enables the ignored test. Let's disable it again in the following PR if it's still flaky.
Why are the changes needed?
Bug fix.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CIs.