[SPARK-34309][BUILD][FOLLOWUP] Upgrade Caffeine to 2.9.2 #33772
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Considering the discussion, it's a little bit possible that that PR is reverted but it's better to upgrade it if we retain that change. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #142573 has finished for PR 33772 at commit
|
Member
Author
|
Thanks. Merging to |
Member
|
+1, LGTM, too. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Aug 22, 2021
…Guava Cache" ### What changes were proposed in this pull request? This pr revert the change of SPARK-34309, includes: - #31517 - #33772 ### Why are the changes needed? 1. No really performance improvement in Spark 2. Added an additional dependency ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass the Jenkins or GitHub Action Closes #33784 from LuciferYang/revert-caffeine. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR upgrades Caffeine to
2.9.2.Caffeine was introduced in SPARK-34309 (#31517). At the time that PR was opened, the latest version of caffeine was
2.9.1but now2.9.2is available.Why are the changes needed?
2.9.2have the following improvements (https://github.com/ben-manes/caffeine/releases/tag/v2.9.2).Does this PR introduce any user-facing change?
No.
How was this patch tested?
CIs.