-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-36457][DOCS] Review and fix issues in Scala/Java API docs #33824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,7 @@ import org.apache.spark.storage.{BlockId, BlockManagerId, BlockNotFoundException | |
| /** | ||
| * Object for grouping error messages from (most) exceptions thrown during query execution. | ||
| */ | ||
| object SparkCoreErrors { | ||
| private[spark] object SparkCoreErrors { | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @karenfeng
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shall we mark |
||
| def rddBlockNotFoundError(blockId: BlockId, id: Int): Throwable = { | ||
| new Exception(s"Could not compute split, block $blockId of RDD $id not found") | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,7 +24,7 @@ import java.util.zip.Checksum | |
| * A variant of [[java.util.zip.CheckedOutputStream]] which can | ||
| * change the checksum calculator at runtime. | ||
| */ | ||
| class MutableCheckedOutputStream(out: OutputStream) extends OutputStream { | ||
| private[spark] class MutableCheckedOutputStream(out: OutputStream) extends OutputStream { | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cc @Ngone51
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM, thanks! |
||
| private var checksum: Checksum = _ | ||
|
|
||
| def setChecksum(c: Checksum): Unit = { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,7 +29,7 @@ import org.apache.spark.deploy.SparkSubmitUtils | |
| import org.apache.spark.internal.Logging | ||
| import org.apache.spark.internal.config._ | ||
|
|
||
| case class IvyProperties( | ||
| private[spark] case class IvyProperties( | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LGTM |
||
| packagesExclusions: String, | ||
| packages: String, | ||
| repositories: String, | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,13 +17,17 @@ | |
|
|
||
| package org.apache.spark.sql.connector.catalog; | ||
|
|
||
| import org.apache.spark.annotation.Evolving; | ||
| import org.apache.spark.sql.catalyst.analysis.NoSuchFunctionException; | ||
| import org.apache.spark.sql.catalyst.analysis.NoSuchNamespaceException; | ||
| import org.apache.spark.sql.connector.catalog.functions.UnboundFunction; | ||
|
|
||
| /** | ||
| * Catalog methods for working with Functions. | ||
| * | ||
| * @since 3.2.0 | ||
| */ | ||
| @Evolving | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| public interface FunctionCatalog extends CatalogPlugin { | ||
|
|
||
| /** | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ | |
|
|
||
| package org.apache.spark.sql.connector.catalog.functions; | ||
|
|
||
| import org.apache.spark.annotation.Evolving; | ||
| import org.apache.spark.sql.catalyst.InternalRow; | ||
| import org.apache.spark.sql.types.DataType; | ||
|
|
||
|
|
@@ -42,7 +43,10 @@ | |
| * | ||
| * @param <S> the JVM type for the aggregation's intermediate state; must be {@link Serializable} | ||
| * @param <R> the JVM type of result values | ||
| * | ||
| * @since 3.2.0 | ||
| */ | ||
| @Evolving | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also please take a look at the following DSV2 changes, thanks! |
||
| public interface AggregateFunction<S extends Serializable, R> extends BoundFunction { | ||
|
|
||
| /** | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @karenfeng