Revert "[SPARK-35011][CORE][3.0] Avoid Block Manager registrations when StopExecutor msg is in-flight" #33961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en StopExecutor msg is in-flight" This reverts commit 0a31f1f.
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #143150 has finished for PR 33961 at commit
|
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Sep 10, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM.
Merged to branch-3.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 10, 2021
…en StopExecutor msg is in-flight" This reverts commit 0a31f1f. ### What changes were proposed in this pull request? Revert #33782 ### Why are the changes needed? It breaks the expected `BlockManager` re-registration (e.g., heartbeat loss of an active executor) due to deferred removal of `BlockManager`, see the check: https://github.com/apache/spark/blob/9cefde8db373a3433b7e3ce328e4a2ce83b1aca2/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala#L551 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass existing tests. Closes #33961 from Ngone51/revert-35011-3.0. Authored-by: yi.wu <yi.wu@databricks.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
Thank you so much, @Ngone51 . |
Contributor
|
Late +1, thanks for working on this @Ngone51 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0a31f1f.
What changes were proposed in this pull request?
Revert #33782
Why are the changes needed?
It breaks the expected
BlockManagerre-registration (e.g., heartbeat loss of an active executor) due to deferred removal ofBlockManager, see the check:spark/core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
Line 551 in 9cefde8
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass existing tests.