[SPARK-36926][SQL] Decimal average mistakenly overflow #34180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenfeng
reviewed
Oct 5, 2021
| @@ -97,7 +97,7 @@ case class Average( | |||
| case d: DecimalType => | |||
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Merging to master |
|
@cloud-fan This PR can't be merged to branch-3.2 directly. Could you open a backport PR? |
|
Test build #143831 has finished for PR 34180 at commit
|
|
Thanks for fixing this quickly @cloud-fan ! |
cloud-fan
added a commit
to cloud-fan/spark
that referenced
this pull request
Oct 6, 2021
This bug was introduced by apache#33177 When checking overflow of the sum value in the average function, we should use the `sumDataType` instead of the input decimal type. fix a regression Yes, the result was wrong before this PR. a new test Closes apache#34180 from cloud-fan/bug. Lead-authored-by: Wenchen Fan <wenchen@databricks.com> Co-authored-by: Wenchen Fan <cloud0fan@gmail.com> Signed-off-by: Gengliang Wang <gengliang@apache.org>
gengliangwang
pushed a commit
that referenced
this pull request
Oct 6, 2021
backport #34180 ### What changes were proposed in this pull request? This bug was introduced by #33177 When checking overflow of the sum value in the average function, we should use the `sumDataType` instead of the input decimal type. ### Why are the changes needed? fix a regression ### Does this PR introduce _any_ user-facing change? Yes, the result was wrong before this PR. ### How was this patch tested? a new test Closes #34193 from cloud-fan/bug. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Gengliang Wang <gengliang@apache.org>
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Dec 8, 2021
backport apache#34180 ### What changes were proposed in this pull request? This bug was introduced by apache#33177 When checking overflow of the sum value in the average function, we should use the `sumDataType` instead of the input decimal type. ### Why are the changes needed? fix a regression ### Does this PR introduce _any_ user-facing change? Yes, the result was wrong before this PR. ### How was this patch tested? a new test Closes apache#34193 from cloud-fan/bug. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Gengliang Wang <gengliang@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This bug was introduced by #33177
When checking overflow of the sum value in the average function, we should use the
sumDataTypeinstead of the input decimal type.Why are the changes needed?
fix a regression
Does this PR introduce any user-facing change?
Yes, the result was wrong before this PR.
How was this patch tested?
a new test