Skip to content

Conversation

@hase1031
Copy link
Contributor

This will fix SPARK-4507.

For pull requests that reference multiple JIRAs in their titles, it would be helpful if the PR merge script offered to close all of them.

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@liuchang0812
Copy link
Contributor

This patch isn't very clear for reviewing, you moved a lot of codes. 👍

@hase1031
Copy link
Contributor Author

I'll try not to move codes more than necessary

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this change the behavior when there are no JIRAs of the correct form in the title, such that we now won't prompt the user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it.

@pwendell
Copy link
Contributor

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Nov 30, 2014

Test build #23951 has started for PR 3428 at commit bf6d64b.

  • This patch merges cleanly.

@pwendell
Copy link
Contributor

LGTM pending tests.

@SparkQA
Copy link

SparkQA commented Nov 30, 2014

Test build #23951 has finished for PR 3428 at commit bf6d64b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23951/
Test PASSed.

@pwendell
Copy link
Contributor

Thanks @aarondav for the review and @hase1031 for this patch. I'll pull it in now.

@asfgit asfgit closed this in 4316a7b Nov 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants