Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR proposes to upgrade Thrift to 0.15.0.

Why are the changes needed?

To addresses CVEs:

Component Name Component Version Name Vulnerability Fixed version
Apache Thrift 0.11.0-4. CVE-2019-0205 0.13.0
Apache Thrift 0.11.0-4. CVE-2019-0210 0.13.0
Apache Thrift 0.11.0-4. CVE-2020-13949 0.14.1

Does this PR introduce any user-facing change?

I think no. CVE-2019-0205 and CVE-2019-0210 are more a bug fix.
CVE-2020-13949 might be valid.

How was this patch tested?

Existing tests should cover.

@SparkQA
Copy link

SparkQA commented Oct 14, 2021

Test build #144228 has finished for PR 34280 at commit 01d95b2.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 14, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48708/

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to fail at some code. Is this a breaking change?

[error] /home/runner/work/spark/spark/sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java:254:1:  error: incompatible types: String cannot be converted to TConfiguration
[error]     return new TSocket(host, port, loginTimeout);

cc @wangyum and @sunchao

@sunchao
Copy link
Member

sunchao commented Oct 14, 2021

seems it's changed by this commit in 0.15.0

@HyukjinKwon HyukjinKwon changed the title [SPARK-36994][BUILD] Update Thrift to 0.15.0 [WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0 Oct 15, 2021
@SparkQA
Copy link

SparkQA commented Oct 18, 2021

Test build #144347 has finished for PR 34280 at commit de3f92f.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 18, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48825/

@HyukjinKwon
Copy link
Member Author

@wangyum
Copy link
Member

wangyum commented Oct 18, 2021

@SparkQA
Copy link

SparkQA commented Oct 18, 2021

Test build #144351 has finished for PR 34280 at commit a796548.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 18, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48829/

@wangyum
Copy link
Member

wangyum commented Oct 18, 2021

@HyukjinKwon It seems we need to port https://issues.apache.org/jira/browse/HIVE-21498:
image

@HyukjinKwon
Copy link
Member Author

Thanks @wangyum. Yeah, probably should better do that. Would you min taking a look when you find some time? I can give a shot too but that would take a while 😢

@wangyum
Copy link
Member

wangyum commented Oct 18, 2021

It seems it only support Thrift 0.13: https://github.com/apache/spark/compare/master...wangyum:thrift-0.13?expand=1
Thrift 0.14.2 will throw exception:
image

Jens-G pushed a commit to apache/thrift that referenced this pull request Oct 18, 2021
@wangyum
Copy link
Member

wangyum commented Oct 19, 2021

We can upgrade to Thrift 0.16 with these changes: https://github.com/apache/spark/compare/master...wangyum:thrift-0.15?expand=1

@HyukjinKwon
Copy link
Member Author

Thanks @wangyum. feel free to take this over!

@HyukjinKwon
Copy link
Member Author

@wangyum feel free to create a PR!

@HyukjinKwon HyukjinKwon deleted the SPARK-36994 branch January 4, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants