-
Notifications
You must be signed in to change notification settings - Fork 29k
[WIP][SPARK-36994][BUILD] Update Thrift to 0.15.0 #34280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
32180d6 to
01d95b2
Compare
|
Test build #144228 has finished for PR 34280 at commit
|
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to fail at some code. Is this a breaking change?
[error] /home/runner/work/spark/spark/sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java:254:1: error: incompatible types: String cannot be converted to TConfiguration
[error] return new TSocket(host, port, loginTimeout);
|
seems it's changed by this commit in 0.15.0 |
01d95b2 to
de3f92f
Compare
|
Test build #144347 has finished for PR 34280 at commit
|
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
@wangyum, I just noticed that we have some diff in Thriftserver. Just to confirm, have you made some modifications to match with Spark's Thriftversion before? e.g.) https://github.com/apache/spark/blob/master/sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java#L241-L283 vs https://github.com/apache/hive/blob/rel/release-2.3.7/service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java#L240-L254 |
|
It is copied from Spark 2.4.0, Not Hive 2.3.7. |
|
Test build #144351 has finished for PR 34280 at commit
|
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
@HyukjinKwon It seems we need to port https://issues.apache.org/jira/browse/HIVE-21498: |
|
Thanks @wangyum. Yeah, probably should better do that. Would you min taking a look when you find some time? I can give a shot too but that would take a while 😢 |
|
It seems it only support Thrift 0.13: https://github.com/apache/spark/compare/master...wangyum:thrift-0.13?expand=1 |
Workaround for this issue: apache/spark#34280 (comment)
|
We can upgrade to Thrift 0.16 with these changes: https://github.com/apache/spark/compare/master...wangyum:thrift-0.15?expand=1 |
|
Thanks @wangyum. feel free to take this over! |
|
@wangyum feel free to create a PR! |


What changes were proposed in this pull request?
This PR proposes to upgrade Thrift to 0.15.0.
Why are the changes needed?
To addresses CVEs:
Does this PR introduce any user-facing change?
I think no. CVE-2019-0205 and CVE-2019-0210 are more a bug fix.
CVE-2020-13949 might be valid.
How was this patch tested?
Existing tests should cover.