Skip to content

[SPARK-4650][SQL] Supporting multi column support in countDistinct function like count(distinct c1,c2..) in Spark SQL #3511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ravipesala wants to merge 2 commits into from
Closed

[SPARK-4650][SQL] Supporting multi column support in countDistinct function like count(distinct c1,c2..) in Spark SQL #3511

ravipesala wants to merge 2 commits into from

Conversation

@ravipesala
Copy link
Contributor

@ravipesala ravipesala commented Nov 28, 2014

Supporting multi column support in countDistinct function like count(distinct c1,c2..) in Spark SQL

@SparkQA
Copy link

SparkQA commented Nov 28, 2014

Test build #23943 has started for PR 3511 at commit 070e12a.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 28, 2014

Test build #23943 has finished for PR 3511 at commit 070e12a.

  • This patch fails Scala style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 28, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23943/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Nov 28, 2014

Test build #23944 has started for PR 3511 at commit cc4dbb1.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 28, 2014

Test build #23944 has finished for PR 3511 at commit cc4dbb1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 28, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23944/
Test PASSed.

marmbrus
marmbrus reviewed Dec 1, 2014
View reviewed changes
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
Copy link
Contributor

@marmbrus marmbrus Dec 1, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think this can just be Multi-column COUNT(DISTINCT ...)

@asfgit asfgit closed this in 6a9ff19 Dec 1, 2014
asfgit pushed a commit that referenced this pull request Dec 1, 2014
@ravipesala @marmbrus
[SPARK-4650][SQL] Supporting multi column support in countDistinct fu…
5006aab 
…nction like count(distinct c1,c2..) in Spark SQL

Supporting multi column support in countDistinct function like count(distinct c1,c2..) in Spark SQL

Author: ravipesala <ravindra.pesala@huawei.com>
Author: Michael Armbrust <michael@databricks.com>

Closes #3511 from ravipesala/countdistinct and squashes the following commits:

cc4dbb1 [ravipesala] style
070e12a [ravipesala] Supporting multi column support in count(distinct c1,c2..) in Spark SQL

(cherry picked from commit 6a9ff19)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@marmbrus
Copy link
Contributor

marmbrus commented Dec 1, 2014

Thanks, merged to master and 1.2 (I made the minor change while merging).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ravipesala @SparkQA @AmplabJenkins @marmbrus