[SPARK-37967][SQL] Literal.create support ObjectType #35255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ping @cloud-fan, I think we can merge this before #35207 |
cloud-fan
reviewed
Jan 20, 2022
| Literal(CatalystTypeConverters.createToCatalystConverter(dataType)(v), dataType) | ||
| case _: DayTimeIntervalType if v.isInstanceOf[Duration] => | ||
| Literal(CatalystTypeConverters.createToCatalystConverter(dataType)(v), dataType) | ||
| case _: ObjectType => Literal(v, dataType) |
Contributor
There was a problem hiding this comment.
shall we do some assertion here? e.g. v.getClass should be or a sub-class of ObjectType.cls
Contributor
Author
There was a problem hiding this comment.
shall we do some assertion here? e.g.
v.getClassshould be or a sub-class ofObjectType.cls
Already have a check in Literal.validateLiteralValue(value, dataType) when constructing Literal
cloud-fan
approved these changes
Jan 20, 2022
Contributor
Author
|
ping @cloud-fan GA passed |
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently , ConstantFolding use
Literal.create()to represent the result of constant.If the data type is ObjectType, such as
ObjectType(classOf[UTF8String]),current
Literal.createwill first convertUTF8StringtoString, then failed to create ObjectType literal.this pr to fix this issue.
Why are the changes needed?
Fix bug
Does this PR introduce any user-facing change?
User can create ObjectType literal use
Literal.create()more safety.How was this patch tested?
Added UT