[SPARK-37931][SQL][FOLLOWUP] Quote the column name of view if needed #35351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peng-Lei
changed the title
Contributor
Author
|
@cloud-fan Could you take a look? Thank you very much. |
cloud-fan
approved these changes
Jan 28, 2022
Contributor
|
thanks, merging to master! |
senthh
pushed a commit
to senthh/spark-1
that referenced
this pull request
Feb 3, 2022
### What changes were proposed in this pull request? Quote the column name of view when `SHOW CREATE TABLE` for view. ### Why are the changes needed? follow up the [#PR](apache#35227). Keep the consistent between table and view when `SHOW CREATE TABLE`. ### Does this PR introduce _any_ user-facing change? Yes，It will change the result of `SHOW CREATE TABLE` for view. eg: ``` "STRUCT<`_c0`, `_c1`>" => "STRUCT<_c0, _c1>" ``` ### How was this patch tested? existed testcase. Closes apache#35351 from Peng-Lei/view-quote-columns. Authored-by: PengLei <peng.8lei@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Quote the column name of view when
SHOW CREATE TABLEfor view.Why are the changes needed?
follow up the #PR. Keep the consistent between table and view when
SHOW CREATE TABLE.Does this PR introduce any user-facing change?
Yes，It will change the result of
SHOW CREATE TABLEfor view.eg:
How was this patch tested?
existed testcase.