Skip to content

[SPARK-4695][SQL] Get result using executeCollect #3547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scwf wants to merge 4 commits into from
Closed

[SPARK-4695][SQL] Get result using executeCollect #3547

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
184c594
using executeCollect instead collect
scwf Dec 2, 2014
0db7ce8
adding debug info
scwf Dec 2, 2014
a60d680
fix test failure
scwf Dec 2, 2014
a5ab68e
Revert "adding debug info"
scwf Dec 2, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ class HiveContext(sc: SparkContext) extends SQLContext(sc) {
command.executeCollect().map(_.head.toString)

case other =>
val result: Seq[Seq[Any]] = toRdd.map(_.copy()).collect().toSeq
val result: Seq[Seq[Any]] = other.executeCollect().toSeq
// We need the types so we can output struct field names
val types = analyzed.output.map(_.dataType)
// Reformat to match hive tab delimited output.
Expand Down Expand Up @@ -416,6 +416,8 @@ object HiveContext {
case (bin: Array[Byte], BinaryType) => new String(bin, "UTF-8")
case (decimal: Decimal, DecimalType()) => // Hive strips trailing zeros so use its toString
HiveShim.createDecimal(decimal.toBigDecimal.underlying()).toString
Copy link
Contributor

@marmbrus marmbrus Dec 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this case can be deleted now. Internal decimal types should never be returned to users.

case (decimal: BigDecimal, DecimalType()) =>
HiveShim.createDecimal(decimal.underlying()).toString
case (other, tpe) if primitiveTypes contains tpe => other.toString
}

Expand Down