Skip to content

Conversation

@zsxwing
Copy link
Member

@zsxwing zsxwing commented Dec 8, 2014

Since sequenceNumberToProcessor and stopped are both protected by the lock sequenceNumberToProcessor, ConcurrentHashMap and volatile is unnecessary. So this PR updated them accordingly.

@SparkQA
Copy link

SparkQA commented Dec 8, 2014

Test build #24220 has started for PR 3634 at commit 0d087ac.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 8, 2014

Test build #24220 has finished for PR 3634 at commit 0d087ac.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24220/
Test PASSed.

@srowen
Copy link
Member

srowen commented Dec 8, 2014

LGTM

@harishreedharan
Copy link
Contributor

+1. Looks good!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use the @GuardedBy("sequenceNumberToProcessor") javax annotation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

external/flume-sink doesn't depend on jsr305. GuardedBy is in jsr305***.jar. However, great to know that we can use GuardedBy in Spark.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, did not realize it was not a javax standard. Thanks.

@aarondav
Copy link
Contributor

aarondav commented Dec 8, 2014

LGTM too, at your discretion you could replace the comment with the annotation or not. Will merge when addressed.

@aarondav
Copy link
Contributor

aarondav commented Dec 9, 2014

Merging into master, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants