[SPARK-38700][SQL] Use error classes in the execution errors of save mode #36350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
MaxGekk
reviewed
Apr 27, 2022
MaxGekk
reviewed
Apr 27, 2022
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala
Show resolved
Hide resolved
MaxGekk
reviewed
Apr 28, 2022
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
Outdated
Show resolved
Hide resolved
Member
|
@panbingkun Could you resolve conflicts, please. |
Contributor
Author
Done, Thanks @MaxGekk |
MaxGekk
approved these changes
May 1, 2022
Member
|
+1, LGTM. Merging to master. |
Member
|
@panbingkun Could you backport the changes to branch-3.3, please. |
Contributor
Author
i just see the message today, sorry! |
This was referenced May 25, 2022
MaxGekk
pushed a commit
that referenced
this pull request
Jun 14, 2022
…save mode ### What changes were proposed in this pull request? Migrate the following errors in QueryExecutionErrors: * unsupportedSaveModeError -> UNSUPPORTED_SAVE_MODE This is a backport of #36350. ### Why are the changes needed? Porting execution errors of unsupported saveMode to new error framework. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Add new UT. Closes #36852 from panbingkun/branch-3.3-SPARK-38700-new. Lead-authored-by: panbingkun <pbk1982@gmail.com> Co-authored-by: panbingkun <84731559@qq.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Migrate the following errors in QueryExecutionErrors:
Why are the changes needed?
Porting execution errors of unsupported saveMode to new error framework.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add new UT.