[SPARK-37939][SQL] Use error classes in the parsing errors of properties #36561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
pinging @MaxGekk |
MaxGekk
reviewed
May 16, 2022
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryParsingErrorsSuite.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala
Outdated
Show resolved
Hide resolved
|
Can one of the admins verify this patch? |
MaxGekk
reviewed
May 17, 2022
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryParsingErrorsSuite.scala
Outdated
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryParsingErrors.scala
Outdated
Show resolved
Hide resolved
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryParsingErrorsSuite.scala
Outdated
Show resolved
Hide resolved
MaxGekk
approved these changes
May 19, 2022
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
+1, LGTM. Merging to master.
Thank you, @panbingkun.
Member
|
@panbingkun Could you backport this to branch-3.3, please. |
MaxGekk
pushed a commit
that referenced
this pull request
Jun 21, 2022
…operties ## What changes were proposed in this pull request? Migrate the following errors in QueryParsingErrors onto use error classes: - cannotCleanReservedNamespacePropertyError => UNSUPPORTED_FEATURE - cannotCleanReservedTablePropertyError => UNSUPPORTED_FEATURE - invalidPropertyKeyForSetQuotedConfigurationError => INVALID_PROPERTY_KEY - invalidPropertyValueForSetQuotedConfigurationError => INVALID_PROPERTY_VALUE - propertiesAndDbPropertiesBothSpecifiedError => UNSUPPORTED_FEATURE This is a backport of #36561. ### Why are the changes needed? Porting parsing errors of partitions to new error framework, improve test coverage, and document expected error messages in tests. ### Does this PR introduce any user-facing change? No ### How was this patch tested? By running new test: ``` $ build/sbt "sql/testOnly *QueryParsingErrorsSuite*" ``` Closes #36916 from panbingkun/branch-3.3-SPARK-37939. Authored-by: panbingkun <pbk1982@gmail.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Migrate the following errors in QueryParsingErrors onto use error classes:
UNSUPPORTED_FEATURE.SET_NAMESPACE_PROPERTY
Why are the changes needed?
Porting parsing errors of partitions to new error framework, improve test coverage, and document expected error messages in tests.
Does this PR introduce any user-facing change?
No
How was this patch tested?
By running new test: