[SPARK-39547][SQL] V2SessionCatalog should not throw NoSuchDatabaseException in loadNamspaceMetadata #36948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
singhpk234
force-pushed
the
fix/loadNamespaceMetadata
branch
from
99c255d to
fb95f9c
Compare
|
Can one of the admins verify this patch? |
cloud-fan
reviewed
Jun 22, 2022
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala
Outdated
Show resolved
Hide resolved
huaxingao
approved these changes
Jun 22, 2022
cloud-fan
pushed a commit
that referenced
this pull request
Jun 23, 2022
…ception in loadNamspaceMetadata
### What changes were proposed in this pull request?
This change attempts to make V2SessionCatalog return NoSuchNameSpaceException rather than NoSuchDataseException
### Why are the changes needed?
if a catalog doesn't overrides `namespaceExists` it by default uses `loadNamespaceMetadata` and in case a `db` not exists loadNamespaceMetadata throws a `NoSuchDatabaseException` which is not catched and we see failures even with `if exists` clause. One such use case we observed was in iceberg table a post test clean up was failing with `NoSuchDatabaseException` now. Also queries such as `DROP TABLE IF EXISTS {}` fails with no such db exception.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Modified the UT to match the proposed behviour
Closes #36948 from singhpk234/fix/loadNamespaceMetadata.
Authored-by: Prashant Singh <psinghvk@amazon.com>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
(cherry picked from commit 9513393)
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Contributor
|
thanks, merging to master/3.3 |
Author
|
Thanks for the review @cloud-fan , @huaxingao ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This change attempts to make V2SessionCatalog return NoSuchNameSpaceException rather than NoSuchDataseException
Why are the changes needed?
if a catalog doesn't overrides
namespaceExistsit by default usesloadNamespaceMetadataand in case adbnot exists loadNamespaceMetadata throws aNoSuchDatabaseExceptionwhich is not catched and we see failures even withif existsclause. One such use case we observed was in iceberg table a post test clean up was failing withNoSuchDatabaseExceptionnow. Also queries such asDROP TABLE IF EXISTS {}fails with no such db exception.Does this PR introduce any user-facing change?
No
How was this patch tested?
Modified the UT to match the proposed behviour