Skip to content

[Minor][Core] fix comments in MapOutputTracker #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
scwf wants to merge 1 commit into from
Closed

[Minor][Core] fix comments in MapOutputTracker #3700

scwf wants to merge 1 commit into from

Conversation

@scwf
Copy link
Contributor

@scwf scwf commented Dec 15, 2014

Using driver and executor in the comments of MapOutputTracker is more clear.

@SparkQA
Copy link

SparkQA commented Dec 15, 2014

Test build #24454 has started for PR 3700 at commit aa68524.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 15, 2014

Test build #24454 has finished for PR 3700 at commit aa68524.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 15, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24454/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Dec 15, 2014

Test build #24455 has started for PR 3700 at commit 61b4e61.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 15, 2014

Test build #24456 has started for PR 3700 at commit b4e3f95.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 15, 2014

Test build #24457 has started for PR 3700 at commit d8a857a.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 15, 2014

Test build #24455 has finished for PR 3700 at commit 61b4e61.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 15, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24455/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Dec 15, 2014

Test build #24456 has finished for PR 3700 at commit b4e3f95.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 15, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24456/
Test FAILed.

@SparkQA
Copy link

SparkQA commented Dec 15, 2014

Test build #24457 has finished for PR 3700 at commit d8a857a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 15, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24457/
Test PASSed.

@scwf
Copy link
Contributor Author

scwf commented Dec 15, 2014

Have fixed the test failure in #3701, so revert debug changes.

@SparkQA
Copy link

SparkQA commented Dec 15, 2014

Test build #24459 has started for PR 3700 at commit aa68524.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 15, 2014

Test build #24459 has finished for PR 3700 at commit aa68524.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Dec 15, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24459/
Test FAILed.

JoshRosen
JoshRosen reviewed Dec 16, 2014
View reviewed changes
core/src/main/scala/org/apache/spark/MapOutputTracker.scala
Copy link
Contributor

@JoshRosen JoshRosen Dec 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar nit: "a -> an".

@JoshRosen
Copy link
Contributor

JoshRosen commented Dec 16, 2014

This looks good to me. Master/driver and worker/executor confusion trips up a lot of people, so I'm glad to fix this. I'm going to merge this into master and branch-1.2.

asfgit pushed a commit that referenced this pull request Dec 16, 2014
@scwf @JoshRosen
[Minor][Core] fix comments in MapOutputTracker
f1f27ec 
Using driver and executor in the comments of ```MapOutputTracker``` is more clear.

Author: wangfei <wangfei1@huawei.com>

Closes #3700 from scwf/commentFix and squashes the following commits:

aa68524 [wangfei] master and worker should be driver and executor

(cherry picked from commit 5c24759)
Signed-off-by: Josh Rosen <joshrosen@databricks.com>
@asfgit asfgit closed this in 5c24759 Dec 16, 2014
@scwf scwf deleted the commentFix branch December 16, 2014 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@scwf @SparkQA @AmplabJenkins @JoshRosen