[SPARK-39716][R] Make currentDatabase/setCurrentDatabase/listCatalogs in SparkR support 3L namespace #37127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengruifeng
force-pushed
the
r_3L_catalog
branch
from
1d7f2c4 to
1c85a35
Compare
zhengruifeng
commented
Jul 8, 2022
| "org.apache.spark.sql.connector.catalog.CatalogNotFoundException: ", | ||
| "Catalog 'zxwtyswklpf' plugin class not found: ", | ||
| "spark.sql.catalog.zxwtyswklpf is not defined")) | ||
| catalogs <- collect(listCatalogs()) |
Contributor
Author
There was a problem hiding this comment.
catalogs is empty here, see #36904 (comment)
HyukjinKwon
reviewed
Jul 8, 2022
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
I think we should fix https://github.com/apache/spark/blob/master/R/pkg/pkgdown/_pkgdown_template.yml#L55 too cc @zero323
HyukjinKwon
approved these changes
Jul 8, 2022
zhengruifeng
changed the title
Contributor
Author
|
merged to master, thank you @HyukjinKwon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add currentDatabase/setCurrentDatabase/listCatalogs
Why are the changes needed?
to support 3L namespace in SparkR
Does this PR introduce any user-facing change?
yes, new API added
How was this patch tested?
added UT