[SPARK-39918][SQL][MINOR] Replace the wording "un-comparable" with "incomparable" in error message #37338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is trivial. I found it when working on #37337 |
MaxGekk
approved these changes
Jul 29, 2022
HyukjinKwon
approved these changes
Jul 29, 2022
Member
|
Merged to master. |
srowen
reviewed
Aug 31, 2022
| case udt: UserDefinedType[_] => genComp(udt.sqlType, c1, c2) | ||
| case _ => | ||
| throw QueryExecutionErrors.cannotGenerateCodeForUncomparableTypeError("compare", dataType) | ||
| throw QueryExecutionErrors.cannotGenerateCodeForIncomparableTypeError("compare", dataType) |
Member
There was a problem hiding this comment.
Don't revert this, but, this is very pedantically techincally incorrect. "Incomparable" means "without peer, the best". "Uncomparable" isn't a word really, but, probably more accurate. Whatev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update the codegen error message for data type which can't be compared by replacing
un-comparablewithincomparableWhy are the changes needed?
Incomparable is the correct wording here
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT