-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-39923][SQL] Multiple query contexts in Spark exceptions #37343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+182
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@cloud-fan @gengliangwang @anchovYu Could you review this PR, please. |
MaxGekk
commented
Jul 29, 2022
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala
Outdated
Show resolved
Hide resolved
cloud-fan
reviewed
Jul 29, 2022
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
Outdated
Show resolved
Hide resolved
Member
Author
|
@cloud-fan @gengliangwang @anchovYu Could you review this PR, please. |
cloud-fan
reviewed
Aug 1, 2022
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
Outdated
Show resolved
Hide resolved
cloud-fan
approved these changes
Aug 1, 2022
gengliangwang
approved these changes
Aug 1, 2022
Member
Author
|
Merging to master. Thank you, @cloud-fan @gengliangwang for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Option[QueryContext]byArray[QueryContext]in Spark exceptions like inSparkRuntimeException.SQLQueryContexttoQueryExecutionErrorsfunctions instead ofOption[SQLQueryContext].getContextOrNull()andgetContextOrNullCode()toSupportQueryContextto get a SQL query context ornull(if it is missed) of an expression.Why are the changes needed?
SQLQueryContexttoQueryExecutionErrorsdirectly simplifies codegen code because it allows to avoid construction of Scala objects likescala.None.Does this PR introduce any user-facing change?
Yes, this PR changes user-facing exceptions.
How was this patch tested?
By running the modified test suites:
and potentially affected tests: