[SPARK-40245][SQL] Fix FileScan equality check when partition or data filter columns are not read #37693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… filter columns are not read
peter-toth
force-pushed
the
SPARK-40245-fix-filescan-equals
branch
from
1f8aad4 to
9c2a67c
Compare
Contributor
Author
|
cc @cloud-fan |
cloud-fan
reviewed
Aug 29, 2022
| spark.read.parquet(path.toString).createOrReplaceTempView("t") | ||
| val df = sql( | ||
| """ | ||
| |SELECT t1.id, t2.id, t3.id |
Contributor
There was a problem hiding this comment.
do we return wrong result before?
Contributor
Author
There was a problem hiding this comment.
No, only exchange reuse didn't happen.
Contributor
|
LGTM, please fix conflicts |
…245-fix-filescan-equals
Contributor
Author
Ok, merged latest |
Contributor
|
thanks, merging to master! |
Contributor
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Unfortunately the fix in #31848 was not correct in all cases. When the partition or data filter contains a column that is not in
readSchema()the filter nornalization inFileScan.equals()doesn't work.Why are the changes needed?
To fix
FileScan.equals()to fix reuse issues.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added new UT.