Skip to content

Conversation

@itholic
Copy link
Contributor

@itholic itholic commented Oct 6, 2022

What changes were proposed in this pull request?

This PR proposes to migrate 25 execution errors onto temporary error classes with the prefix _LEGACY_ERROR_TEMP_2076 to _LEGACY_ERROR_TEMP_2100.

The error classes are prefixed with _LEGACY_ERROR_TEMP_ indicates the dev-facing error messages, and won't be exposed to end users.

Why are the changes needed?

To speed-up the error class migration.

The migration on temporary error classes allow us to analyze the errors, so we can detect the most popular error classes.

Does this PR introduce any user-facing change?

No

How was this patch tested?

$ build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"
$ build/sbt "test:testOnly *SQLQuerySuite"

@itholic itholic marked this pull request as ready for review October 7, 2022 01:35
@itholic itholic changed the title [WIP][SPARK-40663][SQL] Migrate execution errors onto error classes: _LEGACY_ERROR_TEMP_2076-2100 [SPARK-40663][SQL] Migrate execution errors onto error classes: _LEGACY_ERROR_TEMP_2076-2100 Oct 7, 2022
@MaxGekk
Copy link
Member

MaxGekk commented Oct 9, 2022

@itholic Could you resolve conflicts here, please.

@itholic
Copy link
Contributor Author

itholic commented Oct 10, 2022

Resolved!

@MaxGekk
Copy link
Member

MaxGekk commented Oct 10, 2022

@itholic Please, fix the test failures:

[error] /home/runner/work/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:1006:25: parameter 'messageParameters' is already specified at parameter position 2
[error] Note that 'errorSubClass' is not a parameter name of the invoked method.
[error]       messageParameters = Map("optionName" -> optionName))
[error]                         ^
[error] /home/runner/work/spark/spark/sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:1044:25: parameter 'messageParameters' is already specified at parameter position 2
[error] Note that 'errorSubClass' is not a parameter name of the invoked method.
[error]       messageParameters = Map.empty)
[error]                         ^
[error] two errors found

@itholic
Copy link
Contributor Author

itholic commented Oct 11, 2022

Fixed, thanks! :-)

Copy link
Member

@MaxGekk MaxGekk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for CI.

@MaxGekk
Copy link
Member

MaxGekk commented Oct 11, 2022

+1, LGTM. Merging to master.
Thank you, @itholic.

@MaxGekk MaxGekk closed this in 996e407 Oct 11, 2022
@itholic itholic deleted the SPARK-40540-2076-2100 branch April 22, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants