-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-40677][CONNECT][BUILD] Shade more dependency to be able to run separately #38132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @LuciferYang FYI |
|
cc @amaliujia too FYI |
|
question: how do you decide which package needs a shading? |
|
Oh, these were jars missing, andI manually added them (see also #38109 (comment)) |
|
Probably there should be a better way I believe but I am going to merge it first to fix the broken test cases with Maven. |
|
Merged to master. |
| </relocation> | ||
|
|
||
| <relocation> | ||
| <pattern>com.google.android</pattern> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HyukjinKwon Sorry for the late reply
The relocation rule may be incorrect
I think it should be
<pattern>android.annotation</pattern>
<shadedPattern>${spark.shade.packageName}.connect.android.annotation</shadedPattern>
and unzip the assembly jar, the contents are as follows:
ls
META-INF android com google grpc org spark
Not all contents are placed in ${spark.shade.packageName}.connect, which may require further check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey sure, please go ahead with a followup. I just rushed to merge to fix up the broken tests with Maven :-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK~ Maybe do this tomorrow, a little tired today
What changes were proposed in this pull request?
This PR makes the following dependencies shaded:
Before #38109, it worked because related dependences pulled together but now we don't as Spark Connect would be a single jar. This issue has existed from the very first place.
Why are the changes needed?
Otherwise, the tests fails if you build Spark Connect with Maven. SBT does not have the issue because it does the assemply with all dependencies.
Does this PR introduce any user-facing change?
No, the codes are not released out yet.
How was this patch tested?
Manually tested via Maven:
./build/mvn clean package ./python/run-tests --testnames 'pyspark.sql.tests.test_connect_basic'