Skip to content

[SPARK-40702][SQL] Fix partition specs in PartitionsAlreadyExistException #38152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 1 commit into from
Closed

[SPARK-40702][SQL] Fix partition specs in PartitionsAlreadyExistException #38152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...atalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/AlreadyExistException.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ class PartitionsAlreadyExistException(message: String) extends AnalysisException

def this(tableName: String, partitionIdents: Seq[InternalRow], partitionSchema: StructType) = {
this(s"The following partitions already exists in table $tableName:" +
partitionIdents.map(_.toSeq(partitionSchema).zip(partitionSchema.map(_.name))
partitionIdents.map(id => partitionSchema.map(_.name).zip(id.toSeq(partitionSchema))
.map( kv => s"${kv._1} -> ${kv._2}").mkString(",")).mkString("\n===\n"))
}
}
Expand Down
2 changes: 1 addition & 1 deletion ...rc/test/scala/org/apache/spark/sql/execution/command/v2/AlterTableAddPartitionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ class AlterTableAddPartitionSuite
sql(s"ALTER TABLE $t ADD PARTITION (id=1) LOCATION 'loc'" +
" PARTITION (id=2) LOCATION 'loc1'")
}.getMessage
assert(errMsg === s"The following partitions already exists in table $t:2 -> id")
assert(errMsg === s"The following partitions already exists in table $t:id -> 2")

sql(s"ALTER TABLE $t ADD IF NOT EXISTS PARTITION (id=1) LOCATION 'loc'" +
" PARTITION (id=2) LOCATION 'loc1'")
Expand Down