Skip to content

Conversation

@lvshaokang
Copy link
Contributor

What changes were proposed in this pull request?

In the PR, I propose to use error classes in the case of type check failure in collection expressions.

Why are the changes needed?

Migration onto error classes unifies Spark SQL error messages.

Does this PR introduce any user-facing change?

Yes. The PR changes user-facing error messages.

How was this patch tested?

build/sbt "sql/testOnly *SQLQueryTestSuite"
build/sbt "test:testOnly org.apache.spark.SparkThrowableSuite"
build/sbt "test:testOnly *ExpressionTypeCheckingSuite"
build/sbt "test:testOnly *DataFrameFunctionsSuite"
build/sbt "test:testOnly *DataFrameAggregateSuite"
build/sbt "test:testOnly *AnalysisErrorSuite"
build/sbt "test:testOnly *CollectionExpressionsSuite"
build/sbt "test:testOnly *ComplexTypeSuite"
build/sbt "test:testOnly *HigherOrderFunctionsSuite"
build/sbt "test:testOnly *PredicateSuite"
build/sbt "test:testOnly *TypeUtilsSuite"

@lvshaokang
Copy link
Contributor Author

@MaxGekk Please take a look in your free time,thanks!

@MaxGekk
Copy link
Member

MaxGekk commented Oct 11, 2022

+1, LGTM. Merging to master.
Thank you, @lvshaokang.

@MaxGekk MaxGekk closed this in 47d119d Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants