[SPARK-40534][CONNECT][FOLLOW-UP] Support all join types in python client #38243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
amaliujia
commented
Oct 13, 2022
python/pyspark/sql/connect/plan.py
Outdated
Contributor
Author
There was a problem hiding this comment.
Note that in #38157 the feedback was to not support CROSS join so it is not listed here. Whenever it makes sense to have CROSS join then adding the support will be easy and fast.
Contributor
There was a problem hiding this comment.
Why is that? Please keep in mind that these type of decisions increase the pain of porting a pyspark job over to connect.
Contributor
Author
There was a problem hiding this comment.
There were some different opinions for why that is useful. If you think we probably need that back, let's have a discussion first to reach a consensus.
HyukjinKwon
changed the title
amaliujia
force-pushed
the
python_join_types
branch
from
f25da86 to
7a24d64
Compare
HyukjinKwon
approved these changes
Oct 14, 2022
|
Can one of the admins verify this patch? |
Contributor
Author
|
@HyukjinKwon This PR should be ready to merge. |
Contributor
|
Merged into master |
SandishKumarHN
pushed a commit
to SandishKumarHN/spark
that referenced
this pull request
Dec 12, 2022
…ient ### What changes were proposed in this pull request? Following up apache#38157, add all join types support for python. Please note that in the PR we decided to not support CROSS Join now. ### Why are the changes needed? Finish the join type support in Connect. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? UT Closes apache#38243 from amaliujia/python_join_types. Authored-by: Rui Wang <rui.wang@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Following up #38157, add all join types support for python. Please note that in the PR we decided to not support CROSS Join now.
Why are the changes needed?
Finish the join type support in Connect.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT